linux-kernel - Re: [PATCH v2] sched: Drop outdated compile-optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xhsmh7d5b787e.mognet@vschneid.remote.csb>
Date:   Mon, 20 Jun 2022 14:52:53 +0100
From:   Valentin Schneider <vschneid@...hat.com>
To:     Brian Norris <briannorris@...omium.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>
Cc:     Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        linux-kernel@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2] sched: Drop outdated compile-optimization

On 17/06/22 13:34, Brian Norris wrote:
> Looks like this exists from way back in 2011 (commit 095c0aa83e52
> ("sched: adjust scheduler cpu power for stolen time")), when there was a
> little more aggressive use of #if around these variables. The comment
> mostly serves to confuse the reader, although it may arguably apply to
> the (excessive) #ifdef CONFIG_HAVE_SCHED_AVG_IRQ.
>
> Anyway, the #ifdef is not needed, so drop both the comment and the
> "optimization." Any modern compiler will realize this block is not
> needed (for one, update_irq_load_avg() is an empty function when
> !CONFIG_HAVE_SCHED_AVG_IRQ).
>
> Confirmed on:
>
>   x86 gcc 11.2.0 (Debian)
>   x86 clang 13.0.1 (Debian)
>   aarch64-linux-gnu-gcc 11.2.0 (Debian)
>
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Reviewed-by: Valentin Schneider <vschneid@...hat.com>