linux-kernel - Re: [RFC PATCH] Hyper-V: Initialize crash reporting before vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrB8Xvjp2KKQ/JhT@czspare1-lap.sysgo.cz>
Date:   Mon, 20 Jun 2022 15:55:42 +0200
From:   Vit Kabele <vit.kabele@...go.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        linux-hyperv@...r.kernel.org
Cc:     mikelley@...rosoft.com, linux-kernel@...r.kernel.org,
        kys@...rosoft.com
Subject: Re: [RFC PATCH] Hyper-V: Initialize crash reporting before vmbus

On Thu, Jun 16, 2022 at 05:03:16PM +0200, Vitaly Kuznetsov wrote:
> Vit Kabele <vit.kabele@...go.com> writes:
> > Nevertheless, I am not sure about following:
> >
> > 1/ The vmbus_initiate_unload function is called within the panic handler
> > even when the vmbus initialization does not finish (there might be no
> > vmbus at all). This should probably not be problem because the vmbus
> > unload function always checks for current connection state and does
> > nothing when this is "DISCONNECTED". For better readability, it might be
> > better to add separate panic notifier for vmbus and crash reporting.
> >
> > 2/ Wouldn't it be better to extract the whole reporting capability out
> > of the vmbus module, so that it stays present in the kernel even when
> > the vmbus module is possibly unloaded?
> 
> IMHO yes but as you mention hyperv_panic_event() currently does to
> things:
> 1) Initiates VMBus unload
> 2) Reports panic to the hypervisor
> 
> I think untangling them moving the later to arch/x86/hyper-v (and
> arch/arm64/hyperv/) makes sense.
Ok, I will send the complete patch soon.

-- 
Best regards,
Vit Kabele