linux-kernel - Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrAL3CnuQCyReVe3@infradead.org>
Date:   Sun, 19 Jun 2022 22:55:40 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     kernel test robot <lkp@...el.com>, linux-mm@...ck.org,
        kbuild-all@...ts.01.org, hch@...radead.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array
 visibility

On Mon, Jun 20, 2022 at 10:15:31AM +0530, Anshuman Khandual wrote:
> +extern pgprot_t protection_map[16];


externs in .c files are never a good idea.  I'd rather add a helper
function toadd pgprot_encrypted to protection_map to pgprot.c.