linux-kernel - Re: [PATCH 2/2] sched: Remove unused function group_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtB480JTahcvo-+pnfA1ZO3H2mterMO8bPegJV_4BkW8Cw@mail.gmail.com>
Date:   Mon, 20 Jun 2022 07:57:50 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Zhang Qiao <zhangqiao22@...wei.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] sched: Remove unused function group_first_cpu()

On Fri, 17 Jun 2022 at 06:14, Zhang Qiao <zhangqiao22@...wei.com> wrote:
>
> group_first_cpu() is an unused function, remove it.
>
> Signed-off-by: Zhang Qiao <zhangqiao22@...wei.com>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

> ---
>  kernel/sched/sched.h | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 01259611beb9..8f57e9391e82 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1810,15 +1810,6 @@ static inline struct cpumask *group_balance_mask(struct sched_group *sg)
>         return to_cpumask(sg->sgc->cpumask);
>  }
>
> -/**
> - * group_first_cpu - Returns the first CPU in the cpumask of a sched_group.
> - * @group: The group whose first CPU is to be returned.
> - */
> -static inline unsigned int group_first_cpu(struct sched_group *group)
> -{
> -       return cpumask_first(sched_group_span(group));
> -}
> -
>  extern int group_balance_cpu(struct sched_group *sg);
>
>  #ifdef CONFIG_SCHED_DEBUG
> --
> 2.18.0
>