linux-kernel - Re: [PATCH 2/2] mailbox: imx: fix duplicated initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09e8c5cf-12fc-a10e-dacd-338b7e271202@linaro.org>
Date:   Mon, 20 Jun 2022 20:39:35 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Peng Fan <peng.fan@....com>, Jassi Brar <jassisinghbrar@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Tushar Khandelwal <Tushar.Khandelwal@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 2/2] mailbox: imx: fix duplicated initializer

On 07/05/2022 08:52, Peng Fan wrote:
>> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer
>>
>> rxdb field is being initialized twice:
>>
>>   drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-
>> Werror=override-init]
>>     889 |         .rxdb   = imx_mu_generic_rxdb,
>>
>> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Peng Fan <peng.fan@....com>

Thanks for the review. This was a month ago... Anyone willing to pick it up?


Best regards,
Krzysztof