linux-kernel - Re: [PATCH 1/2] mailbox: correct kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220519151903.hvqyrw3yib2mb6yg@bogus>
Date:   Thu, 19 May 2022 16:19:03 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Jassi Brar <jassisinghbrar@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Tushar Khandelwal <Tushar.Khandelwal@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Peng Fan <peng.fan@....com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/2] mailbox: correct kerneldoc

On Thu, May 19, 2022 at 05:14:33PM +0200, Krzysztof Kozlowski wrote:
> On 19/05/2022 17:13, Sudeep Holla wrote:
> > On Sun, May 01, 2022 at 12:34:27PM +0200, Krzysztof Kozlowski wrote:
> >> Correct kerneldoc warnings like:
> >>
> >>   drivers/mailbox/arm_mhu_db.c:47:
> >>     warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> >>   drivers/mailbox/qcom-ipcc.c:58:
> >>     warning: Function parameter or member 'num_chans' not described in 'qcom_ipcc'
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> ---
> >>  drivers/mailbox/arm_mhu_db.c | 2 +-
> > 
> > I thought I had copied it from arm_mhuc.c but apparently not. Anyways,
> > 
> > Acked-by: Sudeep Holla <sudeep.holla@....com>
> > 
> 
> 
> Thanks! Could someone pick these two patches?
> 

They generally go via Jassi's tree.

Hi Jassi,

There is another PCC driver fix that I had acked few weeks back. Please
pick this as well as that when you start finalising patches for your PR
for v5.19.

-- 
Regards,
Sudeep