linux-kernel - Re: [PATCH 4/5] scsi: fnic: Drop reserved request handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a5bed1b-4daf-6f9c-6746-b0592a84d05d@suse.de>
Date:   Mon, 20 Jun 2022 11:15:55 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, axboe@...nel.dk,
        damien.lemoal@...nsource.wdc.com, bvanassche@....org, hch@....de,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, satishkh@...co.com,
        sebaddel@...co.com, kartilak@...co.com
Cc:     linux-rdma@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, mpi3mr-linuxdrv.pdl@...adcom.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        nbd@...er.debian.org
Subject: Re: [PATCH 4/5] scsi: fnic: Drop reserved request handling

On 6/17/22 12:55, John Garry wrote:
> The SCSI core code does not support reserved requests, so drop the
> handling in fnic_pending_aborts_iter().
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   drivers/scsi/fnic/fnic_scsi.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
> index 3d64877bda8d..e7b7f6d73429 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -2019,8 +2019,6 @@ static bool fnic_pending_aborts_iter(struct scsi_cmnd *sc,
>   
>   	if (sc == iter_data->lr_sc || sc->device != lun_dev)
>   		return true;
> -	if (reserved)
> -		return true;
>   
>   	io_lock = fnic_io_lock_tag(fnic, abt_tag);
>   	spin_lock_irqsave(io_lock, flags);

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer