linux-kernel - Re: [PATCH 3/5] blk-mq: Drop blk_mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28d5b284-f9a6-27f8-58e7-ccbbe8fe3214@suse.de>
Date:   Mon, 20 Jun 2022 11:15:34 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, axboe@...nel.dk,
        damien.lemoal@...nsource.wdc.com, bvanassche@....org, hch@....de,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, satishkh@...co.com,
        sebaddel@...co.com, kartilak@...co.com
Cc:     linux-rdma@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, mpi3mr-linuxdrv.pdl@...adcom.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        nbd@...er.debian.org
Subject: Re: [PATCH 3/5] blk-mq: Drop blk_mq_ops.timeout 'reserved' arg

On 6/17/22 12:55, John Garry wrote:
> With new API blk_mq_is_reserved_rq() we can tell if a request is from
> the reserved pool, so stop passing 'reserved' arg. There is actually
> only a single user of that arg for all the callback implementations, which
> can use blk_mq_is_reserved_rq() instead.
> 
> This will also allow us to stop passing the same 'reserved' around the
> blk-mq iter functions next.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   block/blk-mq.c                    | 6 +++---
>   block/bsg-lib.c                   | 2 +-
>   drivers/block/mtip32xx/mtip32xx.c | 5 ++---
>   drivers/block/nbd.c               | 3 +--
>   drivers/block/null_blk/main.c     | 2 +-
>   drivers/mmc/core/queue.c          | 3 +--
>   drivers/nvme/host/apple.c         | 3 +--
>   drivers/nvme/host/fc.c            | 3 +--
>   drivers/nvme/host/pci.c           | 2 +-
>   drivers/nvme/host/rdma.c          | 3 +--
>   drivers/nvme/host/tcp.c           | 3 +--
>   drivers/s390/block/dasd.c         | 2 +-
>   drivers/s390/block/dasd_int.h     | 2 +-
>   drivers/scsi/scsi_error.c         | 3 +--
>   drivers/scsi/scsi_priv.h          | 3 +--
>   include/linux/blk-mq.h            | 2 +-
>   16 files changed, 19 insertions(+), 28 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer