linux-kernel - Re: [PATCH 0/1] can/esd_usb2: Added support for esd CAN-USB/3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220621063501.wxxpotw6vck42gsn@pengutronix.de>
Date:   Tue, 21 Jun 2022 08:35:01 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Frank Jungclaus <frank.jungclaus@....eu>
Cc:     linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Stefan Mätje <stefan.maetje@....eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] can/esd_usb2: Added support for esd CAN-USB/3

Hello Frank,

thanks for your patch!

On 20.06.2022 22:26:02, Frank Jungclaus wrote:
> This patch adds support for the newly available esd CAN-USB/3.
> 
> The USB protocol for the CAN-USB/3 is similar to the protocol used
> for the CAN-USB/2 and the CAN-USB/Micro, so most of the code can be
> shared for all three platforms.
> Due to the fact that the CAN-USB/3 additionally supports CAN FD
> some new functionality / functions are introduced.
> Each occurrence of the term "usb2" within variables, function names,
> etc. is changed to "usb" where it is shared for all three platforms.

Can you split the patch into several ones. Please do the renaming first.
There's some seemingly unrelated reformatting, this could be a separate
patch, too. If this is too much work, you might take this into the
renaming patch. Then add the new device. This makes reviewing a lot
easier.

> The patch has been tested against / should apply to Marc's 
> current testing branch:
> commit 934135149578 ("Merge branch 'document-polarfire-soc-can-controller'")

Note: Better use the linux-can-next/master branch as a base, it will be
only fast forwarded. The testing branch will be rebased. As you don't
depend on any new features, it doesn't make any difference for you.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)