linux-kernel - RE: [PATCH v2] gpio: xilinx: add missing blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB49023428EF7364CF9EFDD80481B39@BY5PR12MB4902.namprd12.prod.outlook.com>
Date:   Tue, 21 Jun 2022 10:21:30 +0000
From:   "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
CC:     "Simek, Michal" <michal.simek@....com>,
        "Neeli, Srinivas" <srinivas.neeli@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: RE: [PATCH v2] gpio: xilinx: add missing blank line after
 declarations

[AMD Official Use Only - General]



> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> Sent: Monday, May 2, 2022 4:31 PM
> To: linux-gpio@...r.kernel.org
> Cc: Michal Simek <michals@...inx.com>; Srinivas Neeli <sneeli@...inx.com>;
> linux-kernel@...r.kernel.org; git <git@...inx.com>; Shubhrajyoti Datta
> <shubhraj@...inx.com>
> Subject: [PATCH v2] gpio: xilinx: add missing blank line after declarations
> 
> Add a missing blank line. No functional changes.
> 
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
> 
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
> 
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> ---
If there are no further comments can it be merged.