linux-kernel - Re: [PATCH v2] gpio: xilinx: add missing blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 15:12:50 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        <linux-gpio@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
CC:     <michal.simek@...inx.com>, <srinivas.neeli@...inx.com>,
        <linux-kernel@...r.kernel.org>, <git@...inx.com>
Subject: Re: [PATCH v2] gpio: xilinx: add missing blank line after
 declarations



On 5/2/22 13:00, Shubhrajyoti Datta wrote:
> Add a missing blank line. No functional changes.
> 
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
> 
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
> 
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> ---
> v2: Update commit message
> 
>   drivers/gpio/gpio-xilinx.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
>   static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
>   {
>   	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
>   	xgpio_set_value32(a, bit, xgpio_readreg(addr));
>   }
>   
>   static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
>   {
>   	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
>   	xgpio_writereg(addr, xgpio_get_value32(a, bit));
>   }
>   


Fixes: 02b3f84d9080 ("gpio: xilinx: Switch to use bitmap APIs")

Reviewed-by: Michal Simek <michal.simek@....com>

Bartosz: Can you please apply it?

Thanks,
Michal