linux-kernel - Re: [PATCH -next] irqchip/apple-aic: Make symbol 'use_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 19:23:52 +0900
From:   Hector Martin <marcan@...can.st>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Sven Peter <sven@...npeter.dev>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] irqchip/apple-aic: Make symbol 'use_fast_ipi'
 static

On 18/06/2022 16.28, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/irqchip/irq-apple-aic.c:231:1: warning:
>  symbol 'use_fast_ipi' was not declared. Should it be static?
> 
> This symbol is not used outside of irq-apple-aic.c, so marks it static.
> 
> Fixes: 2cf68211664a ("irqchip/apple-aic: Add Fast IPI support")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/irqchip/irq-apple-aic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 5ac83185ff47..1c2813ad8bbe 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -228,7 +228,7 @@
>  #define AIC_TMR_EL02_PHYS	AIC_TMR_GUEST_PHYS
>  #define AIC_TMR_EL02_VIRT	AIC_TMR_GUEST_VIRT
>  
> -DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
> +static DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
>  
>  struct aic_info {
>  	int version;
> 
> 

Reviewed-by: Hector Martin <marcan@...can.st>

-- 
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub