linux-kernel - Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bfb0325-0362-2d51-7f25-f389af4bfb68@message-id.googlemail.com>
Date:   Tue, 21 Jun 2022 12:23:56 +0200
From:   Stefan Seyfried <stefan.seyfried@...glemail.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Kenneth Chan <kenneth.t.chan@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stefan Seyfried <seife+kernel@...systems.com>
Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all
 hotkeys

Hi Hans,

On 21.06.22 11:26, Hans de Goede wrote:
> Hi,
> 
> On 6/20/22 20:10, Stefan Seyfried wrote:
>> Well, the non-working backlight is coming from the i915 driver, but as this is a very old Chipset (i855 GM) I'd rather be happy it works at all instead of complaining ;-)
>> (I have another machine of similar age, hp nc6000 with ati graphics, and there is no way getting it to work somewhat reliably at all)
> 
> Ah right, you've got a panasonic + a native intel backlight device.
> 
> We are going to need a quirk to (eventually also depending on other changes)
> disable the broken intel backlight device.
> 
> But that won't fix the keys issue, at least not without an extra
> quirk just for that.
> 
> I wonder if your machine supports the backlight control part of
> the ACPI video bus at all. If not that would explain why it is
> not reporting brightness keys and that would also give us a way
> to solve this without an extra quirk.
> 
> And that would actually also avoid the need for a backlight
> quirk too.
> 
> Can you pass "acpi_backlight=video" on the kernel commandline
> and see if a /sys/class/backlight/acpi_video0 device then
> shows up. If it does _not_ show up then indeed there is no
> ACPI backlight control at all.

Nothing new shows up, just panasonic and intel_backlight as before.

> In that case please give the attached patches a try on top
> of my last series.

they do not fix the brightness keys for me.
I did not have time to put in some debugging and will be traveling for 
the rest of the week, but I'll take the toughbook with me and will try 
to debug this later ;-)

> The acpi_video patch should fix your brightness keys then and

apparently it does not :-(

> the extra panasonic-laptop patch should not make any difference
> for the available /sys/class/backlight devices on your laptop,
> while filtering out the broken panasonic backlight on Kenneth's
> device.

Yes, the panasonic backlight does still work on my machine.

Best regards,

	Stefan
-- 
Stefan Seyfried

"For a successful technology, reality must take precedence over
  public relations, for nature cannot be fooled." -- Richard Feynman