linux-kernel - Re: [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ca11af0-9c13-4e41-07fd-7fe90f202667@foss.st.com>
Date:   Tue, 21 Jun 2022 15:40:48 +0200
From:   Pierre Yves MORDRET <pierre-yves.mordret@...s.st.com>
To:     Alain Volmat <alain.volmat@...s.st.com>, <wsa@...nel.org>,
        <robh+dt@...nel.org>
CC:     <mark.rutland@....com>, <mcoquelin.stm32@...il.com>,
        <alexandre.torgue@...s.st.com>, <linux-i2c@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <fabrice.gasnier@...s.st.com>,
        <amelie.delaunay@...s.st.com>
Subject: Re: [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc

Hi All

Look good to me.

Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@...s.st.com>

Regards

On 6/20/22 12:54, Alain Volmat wrote:
> Add a new compatible for the stm32mp13.  Fast Mode Plus control
> register address differ from the one for STM32MP15.
> 
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index b29d8e476342..9946b330ddce 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -410,6 +410,12 @@ static const struct stm32f7_i2c_setup stm32mp15_setup = {
>  	.fmp_clr_offset = 0x40,
>  };
>  
> +static const struct stm32f7_i2c_setup stm32mp13_setup = {
> +	.rise_time = STM32F7_I2C_RISE_TIME_DEFAULT,
> +	.fall_time = STM32F7_I2C_FALL_TIME_DEFAULT,
> +	.fmp_clr_offset = 0x4,
> +};
> +
>  static inline void stm32f7_i2c_set_bits(void __iomem *reg, u32 mask)
>  {
>  	writel_relaxed(readl_relaxed(reg) | mask, reg);
> @@ -2469,6 +2475,7 @@ static const struct dev_pm_ops stm32f7_i2c_pm_ops = {
>  static const struct of_device_id stm32f7_i2c_match[] = {
>  	{ .compatible = "st,stm32f7-i2c", .data = &stm32f7_setup},
>  	{ .compatible = "st,stm32mp15-i2c", .data = &stm32mp15_setup},
> +	{ .compatible = "st,stm32mp13-i2c", .data = &stm32mp13_setup},
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, stm32f7_i2c_match);

-- 
--
~ Py MORDRET
--