linux-kernel - Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d04c05771ded0f8302d716fa5289d94df27c8eb.camel@toradex.com>
Date:   Wed, 22 Jun 2022 08:38:04 +0200
From:   Andrejs Cainikovs <andrejs.cainikovs@...adex.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Francesco Dolcini <francesco.dolcini@...adex.com>
Cc:     Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz

On Tue, 2022-06-21 at 21:50 +0200, Marc Kleine-Budde wrote:
> On 21.06.2022 20:07:49, Francesco Dolcini wrote:
> > Hello Shawn, just a ping on this.
> > 
> > Francesco
> > 
> > On Thu, May 12, 2022 at 12:40:19PM +0200, Andrejs Cainikovs wrote:
> > > Update SPI CAN controller clock to match current hardware design.
> > > 
> > > Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@...adex.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > > index 0d84d29e70f1..d309bc0ab8f6 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > > @@ -32,10 +32,10 @@ backlight: backlight {
> > >         };
> > >  
> > >         /* Fixed clock dedicated to SPI CAN controller */
> > > -       clk20m: oscillator {
> > > +       clk40m: oscillator {
> > >                 compatible = "fixed-clock";
> > >                 #clock-cells = <0>;
> > > -               clock-frequency = <20000000>;
> > > +               clock-frequency = <40000000>;
> > >         };
> > >  
> > >         gpio-keys {
> > > @@ -194,7 +194,7 @@ &ecspi3 {
> > >  
> > >         can1: can@0 {
> > >                 compatible = "microchip,mcp251xfd";
> > > -               clocks = <&clk20m>;
> > > +               clocks = <&clk40m>;
> > >                 interrupts-extended = <&gpio1 6
> > > IRQ_TYPE_EDGE_FALLING>;
> 
> You don't want to use an edge triggered interrupt with the mcp251xfd
> chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
> 
> regards,
> Marc
> 
Hi Marc,

This particular change is not about interrupts. But thanks for a hint,
I'll make sure this is addressed.

Best regards,
Andrejs Cainikovs.