linux-kernel - Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220622065155.uoo2matz36a45nfa@pengutronix.de>
Date:   Wed, 22 Jun 2022 08:51:55 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Andrejs Cainikovs <andrejs.cainikovs@...adex.com>
Cc:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz

On 22.06.2022 08:38:04, Andrejs Cainikovs wrote:
> > > >         can1: can@0 {
> > > >                 compatible = "microchip,mcp251xfd";
> > > > -               clocks = <&clk20m>;
> > > > +               clocks = <&clk40m>;
> > > >                 interrupts-extended = <&gpio1 6
> > > > IRQ_TYPE_EDGE_FALLING>;
> > 
> > You don't want to use an edge triggered interrupt with the mcp251xfd
> > chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
> 
> This particular change is not about interrupts.

Sure, I just noticed it.

> But thanks for a hint, I'll make sure this is addressed.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)