linux-kernel - Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mte52khd.wl-maz@kernel.org>
Date:   Wed, 22 Jun 2022 09:03:26 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Liang He <windhl@....com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        Miaoqian Lin <linmq006@...il.com>
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()

+ Miaoqian Lin

On Wed, 22 Jun 2022 07:21:38 +0100,
Liang He <windhl@....com> wrote:
> 
> We need to add missing of_node_get() for of_find_matching_node() to
> keep refcount balance.
> 
> Note: of_find_matching_node() will decrease the refcount of its first
> arg.
> 
> Signed-off-by: Liang He <windhl@....com>

[...]

Please send these refcount fixes as a series for all the irqchip
drivers, not one every other day.

And please synchronise with Miaoqian Lin, as you are obviously both
chasing the same bugs.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.