linux-kernel - Re:Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <229e8ea9.5a09.1818a7b7a35.Coremail.windhl@126.com>
Date:   Wed, 22 Jun 2022 16:15:56 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Marc Zyngier" <maz@...nel.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        "Miaoqian Lin" <linmq006@...il.com>
Subject: Re:Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()



At 2022-06-22 16:03:26, "Marc Zyngier" <maz@...nel.org> wrote:
>+ Miaoqian Lin
>
>On Wed, 22 Jun 2022 07:21:38 +0100,
>Liang He <windhl@....com> wrote:
>> 
>> We need to add missing of_node_get() for of_find_matching_node() to
>> keep refcount balance.
>> 
>> Note: of_find_matching_node() will decrease the refcount of its first
>> arg.
>> 
>> Signed-off-by: Liang He <windhl@....com>
>
>[...]
>
>Please send these refcount fixes as a series for all the irqchip
>drivers, not one every other day.
>

Sorry, I will group similar bugs  in future.


>And please synchronise with Miaoqian Lin, as you are obviously both
>chasing the same bugs.
>
>Thanks,
>
>	M.

Yes,  before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.

By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.

>
>-- 
>Without deviation from the norm, progress is not possible.