linux-kernel - Re: [PATCH v3] arm/mm: Fix refcount leak bugs in cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87dd706a-6777-374f-1d41-7d791727697f@kernel.org>
Date:   Wed, 22 Jun 2022 10:58:49 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Liang He <windhl@....com>, linux@...linux.org.uk,
        rmk+kernel@...linux.org.uk, wangkefeng.wang@...wei.com,
        ardb@...nel.org, arnd@...db.de, akpm@...ux-foundation.org,
        rppt@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] arm/mm: Fix refcount leak bugs in cache

On 19/06/2022 03:39, Liang He wrote:
> In feroceon_of_init() and tauros2_init(), of_find_matching_node()
> will return a node pointer with refcount incremented. We should
> use of_node_put() in fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>
> ---
>  changelog:
> 
>  v3: (1) merge arm/mm leak bugs (2) fix bugs intro-ed by v2
>  v2: (1) use real name (2) normalize coding style
>  v1: (1) fix leak bug
> 

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof