linux-kernel - Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6abb20a4-1858-3e04-ed5b-dff18110e58a@kernel.org>
Date:   Wed, 22 Jun 2022 11:02:15 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Liang He <windhl@....com>, tglx@...utronix.de, maz@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()

On 22/06/2022 08:21, Liang He wrote:
> We need to add missing of_node_get() for of_find_matching_node() to
> keep refcount balance.
> 
> Note: of_find_matching_node() will decrease the refcount of its first
> arg.
> 
> Signed-off-by: Liang He <windhl@....com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 ++
>  1 file changed, 2 insertions(+)

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof