linux-kernel - Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0b562d2-fd93-647f-0980-ceadb3a48677@gmail.com>
Date:   Wed, 22 Jun 2022 17:39:14 +0800
From:   Miaoqian Lin <linmq006@...il.com>
To:     Liang He <windhl@....com>, Marc Zyngier <maz@...nel.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()

Hi,

On 2022/6/22 16:34, Liang He wrote:
>
>
> At 2022-06-22 16:29:49, "Marc Zyngier" <maz@...nel.org> wrote:
>> On Wed, 22 Jun 2022 09:15:56 +0100,
>> "Liang He" <windhl@....com> wrote:
>>>
>>>
>>> At 2022-06-22 16:03:26, "Marc Zyngier" <maz@...nel.org> wrote:
>>>> + Miaoqian Lin
>>>>
>>>> On Wed, 22 Jun 2022 07:21:38 +0100,
>>>> Liang He <windhl@....com> wrote:
>>>>> We need to add missing of_node_get() for of_find_matching_node() to
>>>>> keep refcount balance.
>>>>>
>>>>> Note: of_find_matching_node() will decrease the refcount of its first
>>>>> arg.
>>>>>
>>>>> Signed-off-by: Liang He <windhl@....com>
>>>> [...]
>>>>
>>>> Please send these refcount fixes as a series for all the irqchip
>>>> drivers, not one every other day.
>>>>
>>> Sorry, I will group similar bugs  in future.
>>>
>>>
>>>> And please synchronise with Miaoqian Lin, as you are obviously both
>>>> chasing the same bugs.
>>>>
>>>> Thanks,
>>>>
>>>> 	M.
>>> Yes, before I send any new bug, I will confirm that this bug has not
>>> been reported in lore.kernel.org.
>> This is not what I meant. I am asking you to actively coordinate with
>> Miaoqian, working with them as a team instead of you both sending
>> competing series. I would like to see one series with patches from you
>> both.
> OK, I get it. This depends on Miaoqian.

Sure, I would like to work with Liang to fix these bugs.

>
> @linm006@...il.com
>
>>> By the way, this is a bug missing |GET|, not |PUT|, which is
>>> different with Miaoqian's and my patches before.
It's a nice catch and I haven't noticed before.
>> Well, yet another reason for you both to work together, as you are
>> complementing each other.
>>
>> Thanks,
>>
>> 	M.
>>
>> -- 
>> Without deviation from the norm, progress is not possible.