linux-kernel - Re: [PATCH] ARC:mm:Fix syntax errors in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 05:38:52 -0400 (EDT)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Shahab Vahedi <Shahab.Vahedi@...opsys.com>
cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Jilin Yuan <yuanjilin@...rlc.com>,
        "vgupta@...nel.org" <vgupta@...nel.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments



On Wed, 22 Jun 2022, Shahab Vahedi wrote:

> On 6/22/22 11:16, Julia Lawall wrote:
> >
> >
> > On Wed, 22 Jun 2022, Shahab Vahedi wrote:
> >
> >> On 6/22/22 10:30, Bagas Sanjaya wrote:
> >>
> >>> I think that this kind of cleanup patches (typofixes) are best done
> >>> as part of **actual** work on the code in question (for example
> >>> refactoring or fixing build errors).
> >>
> >> Amen!
> >
> > So code that is fine will have typos forever?  Fixing typos in comments
> > doesn't break git blame for the following code.  And typos in comments
> > give a bad impression about the state of the code in general.
>
> Of course not! Documentation is as important as the code, if not even more.
> However, fixing typos to increase your commit counts to a reputable project
> is not fine either. For instance, many of these proposed fixes are targeting
> one single typo at a time. Couldn't they just be sent altogether!?!

I have the impression that the person is just trying to figure out the
patch submission process.  For example, the subject lines are not
formatter in the standard way (I sent the person a private email about
that).  Perhaps just let him know about how you would rather have received
the patches.

julia