linux-kernel - Re: [PATCH v6 1/6] arm64: dts: qcom: sm8350: Replace integers with rpmpd defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 12:07:45 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Robert Foss <robert.foss@...aro.org>, bjorn.andersson@...aro.org,
        agross@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        robh+dt@...nel.org, krzk+dt@...nel.org, jonathan@...ek.ca,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v6 1/6] arm64: dts: qcom: sm8350: Replace integers with
 rpmpd defines



On 22.06.2022 01:34, Robert Foss wrote:
> Replace &rpmhpd power domain integers with their respective defines
> in order to improve legibility.
> 
> Signed-off-by: Robert Foss <robert.foss@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index c0137bdcf94b..52428b6df64e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -1656,8 +1656,8 @@ mpss: remoteproc@...0000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd 0>,
> -					<&rpmhpd 12>;
> +			power-domains = <&rpmhpd SM8350_CX>,
> +					<&rpmhpd SM8350_MSS>;
>  			power-domain-names = "cx", "mss";
>  
>  			interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>;
> @@ -2167,8 +2167,8 @@ slpi: remoteproc@...0000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd 4>,
> -					<&rpmhpd 5>;
> +			power-domains = <&rpmhpd SM8350_LCX>,
> +					<&rpmhpd SM8350_LMX>;
>  			power-domain-names = "lcx", "lmx";
>  
>  			memory-region = <&pil_slpi_mem>;
> @@ -2235,8 +2235,8 @@ cdsp: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd 0>,
> -					<&rpmhpd 10>;
> +			power-domains = <&rpmhpd SM8350_CX>,
> +					<&rpmhpd SM8350_MXC>;
>  			power-domain-names = "cx", "mxc";
>  
>  			interconnects = <&compute_noc MASTER_CDSP_PROC &mc_virt SLAVE_EBI1>;
> @@ -2540,8 +2540,8 @@ adsp: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd 4>,
> -					<&rpmhpd 5>;
> +			power-domains = <&rpmhpd SM8350_LCX>,
> +					<&rpmhpd SM8350_LMX>;
>  			power-domain-names = "lcx", "lmx";
>  
>  			memory-region = <&pil_adsp_mem>;