linux-kernel - Re: [PATCH v2 1/2] spi: aspeed: Add pr_debug in aspeed_spi_dirmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 12:34:12 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Cédric Le Goater <clg@...d.org>
Cc:     linux-spi@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        Andrew Jeffery <andrew@...id.au>, openbmc@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org,
        Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>,
        Mark Brown <broonie@...nel.org>, Joel Stanley <joel@....id.au>,
        Pratyush Yadav <p.yadav@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] spi: aspeed: Add pr_debug in
 aspeed_spi_dirmap_create()

Dear Cédric,


Am 22.06.22 um 11:42 schrieb Cédric Le Goater:
> It helps to analyze the default setting of the control register.

Maybe paste the new log line to the commit message.

> Signed-off-by: Cédric Le Goater <clg@...d.org>
> ---
>   drivers/spi/spi-aspeed-smc.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
> index 496f3e1e9079..ac64be289e59 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -558,6 +558,14 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc)
>   	u32 ctl_val;
>   	int ret = 0;
>   
> +	dev_dbg(aspi->dev,

The commit message summary says `pr_debug()`.

> +		"CE%d %s dirmap [ 0x%.8llx - 0x%.8llx ] OP %#x mode:%d.%d.%d.%d naddr:%#x ndummies:%#x\n",
> +		chip->cs, op->data.dir == SPI_MEM_DATA_IN ? "read" : "write",
> +		desc->info.offset, desc->info.offset + desc->info.length,
> +		op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth,
> +		op->dummy.buswidth, op->data.buswidth,
> +		op->addr.nbytes, op->dummy.nbytes);
> +
>   	chip->clk_freq = desc->mem->spi->max_speed_hz;
>   
>   	/* Only for reads */

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul