linux-kernel - Re: [PATCH -next] soc: mediatek: SVS: Make svs_resume and svs_suspend defined when CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 15:55:14 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Jin Xiaoyun <jinxiaoyun2@...wei.com>,
        angelogioacchino.delregno@...labora.com, khilman@...libre.com,
        zhengbin13@...wei.com, gaochao49@...wei.com
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] soc: mediatek: SVS: Make svs_resume and svs_suspend
 defined when CONFIG_PM_SLEEP is y



On 22/06/2022 03:34, Jin Xiaoyun wrote:
> The svs_resume and svs_suspend is defined through SIMPLE_DEV_PM_OPS. If CONFIG_PM_SLEEP

SIMPLE_DEV_PM_OPS is deprecated. The correct fix is to use 
DEFINE_SIMPLE_DEV_PM_OPS().

Regards,
Matthias

> is not defined, SIMPLE_DEV_PM_OPS is equivalent to an empty function. In this case,
> the defination of svs_resume and svs_suspend is meaningless.
> 
> Fix build error:
> drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function]
> drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]
> 
> Signed-off-by: Jin Xiaoyun <jinxiaoyun2@...wei.com>
> ---
>   drivers/soc/mediatek/mtk-svs.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 606a00a2e57d..8440058784dc 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1478,6 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
>   	return 0;
>   }
> 
> +#ifdef CONFIG_PM_SLEEP
>   static int svs_suspend(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
> @@ -1537,6 +1538,7 @@ static int svs_resume(struct device *dev)
> 
>   	return 0;
>   }
> +#endif
> 
>   static int svs_bank_resource_setup(struct svs_platform *svsp)
>   {
> --
> 2.25.1
>