[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YrMfKRF+13GZvRc5@orome>
Date: Wed, 22 Jun 2022 15:54:49 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>,
linus.walleij@...aro.org, brgl@...ev.pl
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
u.kleine-koenig@...gutronix.de, lee.jones@...aro.org,
andrew@...n.ch, thomas.petazzoni@...e-electrons.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH v4 3/3] dt-bindings: gpio: gpio-mvebu: document offset
and marvell,pwm-offset
On Thu, May 26, 2022 at 01:29:46PM +1200, Chris Packham wrote:
> The offset and marvell,pwm-offset properties weren't in the old binding.
> Add them based on the existing usage in the driver and board DTS when
> the marvell,armada-8k-gpio compatible is used.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>
> Notes:
> Changes in v4:
> - Reword commit message slightly
> - Add review from Krzysztof
> Changes in v3:
> - Split off from 1:1 conversion patch
>
> Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml b/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> index 459ec35864fe..f1bd1e6b2e1f 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mvebu.yaml
> @@ -45,6 +45,10 @@ properties:
> - const: pwm
> minItems: 1
>
> + offset:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Offset in the register map for the gpio registers (in bytes)
> +
> interrupts:
> description: |
> The list of interrupts that are used for all the pins managed by this
> @@ -68,6 +72,10 @@ properties:
> "#gpio-cells":
> const: 2
>
> + marvell,pwm-offset:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Offset in the register map for the pwm registers (in bytes)
> +
It would probably have been better to add multiple compatible strings to
hide parameters like this, but given that this has been in the DTS files
for more than a year at this point, it's probably too late now.
Acked-by: Thierry Reding <thierry.reding@...il.com>
Linus, Bartosz, will you pick up the series into the GPIO tree?
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists