[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJncD7RuTTLoRS_pzvn729_SX5Xsv6Pub44eCD_RbbANjn9joA@mail.gmail.com>
Date: Thu, 23 Jun 2022 11:44:29 +0800
From: sunliming <kelulanainsley@...il.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
sunliming@...ino.cn
Subject: Re: [PATCH] walk_component(): get inode in lookup_slow branch
statement block
Al Viro <viro@...iv.linux.org.uk> 于2022年6月22日周三 18:35写道:
>
> On Wed, Jun 22, 2022 at 04:51:46PM +0800, sunliming wrote:
> > The inode variable is used as a parameter by the step_into function,
> > but is not assigned a value in the sub-lookup_slow branch path. So
> > get the inode in the sub-lookup_slow branch path.
>
> Take a good look at handle_mounts() and the things it does when
> *not* in RCU mode (i.e. LOOKUP_RCU is not set). Specifically,
> *inode = d_backing_inode(path->dentry);
> *seqp = 0; /* out of RCU mode, so the value doesn't matter */
> this part.
>
> IOW, the values passed to step_into() in inode/seq are overridden unless
> we stay in RCU mode. And if we'd been through lookup_slow(), we'd been
> out of RCU mode since before we called step_into().
It might be more appropriate and easier to understand to do this
before parameter passing in the top-level walk_component function?
Powered by blists - more mailing lists