linux-kernel - Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcQcKaYUP_JsmTFOY-pbOR39+TMw=5ADbb2BRGoMijCMw@mail.gmail.com>
Date:   Thu, 23 Jun 2022 23:20:49 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Felix Schlepper <f3sch.git@...look.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling

On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@...look.com> wrote:
>
> Moved error handling to one common block.
> This removes double checking if all txb->fragments[]
> were initialized.
> The original code worked fine, but this is cleaner.

...

> +err_free:
> +       while (--i >= 0)

  while (i--)

will suffice.

> +               dev_kfree_skb_any(txb->fragments[i]);
> +       kfree(txb);
> +
> +       return NULL;

-- 
With Best Regards,
Andy Shevchenko