[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220624052118.GT16517@kadam>
Date: Fri, 24 Jun 2022 08:21:18 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Felix Schlepper <f3sch.git@...look.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-staging@...ts.linux.dev,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling
On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@...look.com> wrote:
> >
> > Moved error handling to one common block.
> > This removes double checking if all txb->fragments[]
> > were initialized.
> > The original code worked fine, but this is cleaner.
>
> ...
>
> > +err_free:
> > + while (--i >= 0)
>
> while (i--)
>
> will suffice.
>
Either one is fine. You prefer this format. I prefer that other
format. I told Felix he could use either format without expressing any
bias and he chose my format. That means he loves me more.
regards,
dan carpenter
Powered by blists - more mailing lists