[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNARaB8-4mm4sZwH2DxGE=GAhS8HiF+-uT9suiHYHe8PgwQ@mail.gmail.com>
Date: Thu, 23 Jun 2022 18:45:37 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Jiri Slaby <jslaby@...e.cz>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andi Kleen <andi@...stfloor.org>,
Michal Marek <michal.lkml@...kovi.net>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] kbuild, link-vmlinux: Don't delete output files with make -i
On Thu, Jun 23, 2022 at 5:31 PM Jiri Slaby <jslaby@...e.cz> wrote:
>
> From: Andi Kleen <andi@...stfloor.org>
>
> make -i is useful to see output files which normally get deleted on an
> error. Make this work with link-vmlinux.sh too. Don't delete the output
> files on error when make -i is used.
>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: linux-kbuild@...r.kernel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> ---
I am afraid you missed this commit:
commit 51eb95e2da41802454f48b9afeb4d96a77295035
Author: Andi Kleen <ak@...ux.intel.com>
Date: Tue May 4 20:35:27 2021 -0700
kbuild: Don't remove link-vmlinux temporary files on exit/signal
Keep them around until they are cleaned up by make clean. This
uses a bit more disk space, but makes it easier to debug any
problems with the kernel link process.
Suggested-by: Masahiro Yamada <masahiroy@...nel.org>
Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> scripts/link-vmlinux.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index eecc1863e556..d21759aad4f3 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -193,6 +193,11 @@ sorttable()
> # Delete output files in case of error
> cleanup()
> {
> + # don't delete for make -i
> + case "$MFLAGS" in
> + *-i*) return ;;
> + esac
> +
> rm -f .btf.*
> rm -f System.map
> rm -f vmlinux
> --
> 2.36.1
>
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists