linux-kernel - Re: [PATCH] kbuild, link-vmlinux: Don't delete output files with make -i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <217838e7-f840-a957-74cc-d878ae0b1820@kernel.org>
Date:   Thu, 23 Jun 2022 11:50:12 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] kbuild, link-vmlinux: Don't delete output files with make
 -i

On 23. 06. 22, 11:45, Masahiro Yamada wrote:
> On Thu, Jun 23, 2022 at 5:31 PM Jiri Slaby <jslaby@...e.cz> wrote:
>>
>> From: Andi Kleen <andi@...stfloor.org>
>>
>> make -i is useful to see output files which normally get deleted on an
>> error.  Make this work with link-vmlinux.sh too. Don't delete the output
>> files on error when make -i is used.
>>
>> Cc: Masahiro Yamada <masahiroy@...nel.org>
>> Cc: Michal Marek <michal.lkml@...kovi.net>
>> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
>> Cc: linux-kbuild@...r.kernel.org
>> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> ---
> 
> 
> 
> I am afraid you missed this commit:
> 
> 
> 
> commit 51eb95e2da41802454f48b9afeb4d96a77295035
> Author: Andi Kleen <ak@...ux.intel.com>
> Date:   Tue May 4 20:35:27 2021 -0700
> 
>      kbuild: Don't remove link-vmlinux temporary files on exit/signal

Oops, thanks a lot for pointing out. We are going through the Andi's LTO 
patches and this went unnoticed as it was changed differently (and 
rebase succeeded). Now dropped from the queue.

thanks,
-- 
js
suse labs