linux-kernel - Re: [PATCH 7/7] platform/chrome: cros_ec_proto: add Kunit test for cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTcQTWMWHyT5=Va1gijyLNsMSM8LQiNU79RWLH-1O4GhCg@mail.gmail.com>
Date:   Thu, 23 Jun 2022 09:40:15 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Tzung-Bi Shih <tzungbi@...nel.org>
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        "open list:CHROME HARDWARE PLATFORM SUPPORT" 
        <chrome-platform@...ts.linux.dev>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] platform/chrome: cros_ec_proto: add Kunit test for cros_ec_cmd()

On Tue, Jun 21, 2022 at 9:11 PM Tzung-Bi Shih <tzungbi@...nel.org> wrote:
>
> cros_ec_cmd() is a wrapper of cros_ec_cmd_xfer_status().
>
> Add Kunit test for cros_ec_cmd().
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@...nel.org>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>  drivers/platform/chrome/cros_ec_proto_test.c | 48 ++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
> index 6b26ce3104f4..2ff2783fedfb 100644
> --- a/drivers/platform/chrome/cros_ec_proto_test.c
> +++ b/drivers/platform/chrome/cros_ec_proto_test.c
> @@ -2592,6 +2592,53 @@ static void cros_ec_proto_test_get_sensor_count_legacy(struct kunit *test)
>         }
>  }
>
> +static void cros_ec_proto_test_ec_cmd(struct kunit *test)
> +{
> +       struct cros_ec_proto_test_priv *priv = test->priv;
> +       struct cros_ec_device *ec_dev = &priv->ec_dev;
> +       struct ec_xfer_mock *mock;
> +       int ret;
> +       u8 out[3], in[2];
> +
> +       ec_dev->max_request = 0xff;
> +       ec_dev->max_response = 0xee;
> +
> +       out[0] = 0xdd;
> +       out[1] = 0xcc;
> +       out[2] = 0xbb;
> +
> +       {
> +               u8 *data;
> +
> +               mock = cros_kunit_ec_xfer_mock_add(test, 2);
> +               KUNIT_ASSERT_PTR_NE(test, mock, NULL);
> +
> +               data = (u8 *)mock->o_data;
> +               data[0] = 0xaa;
> +               data[1] = 0x99;
> +       }
> +
> +       ret = cros_ec_cmd(ec_dev, 0x88, 0x77, out, ARRAY_SIZE(out), in, ARRAY_SIZE(in));
> +       KUNIT_EXPECT_EQ(test, ret, 2);
> +
> +       {
> +               u8 *data;
> +
> +               mock = cros_kunit_ec_xfer_mock_next();
> +               KUNIT_EXPECT_PTR_NE(test, mock, NULL);
> +
> +               KUNIT_EXPECT_EQ(test, mock->msg.version, 0x88);
> +               KUNIT_EXPECT_EQ(test, mock->msg.command, 0x77);
> +               KUNIT_EXPECT_EQ(test, mock->msg.insize, ARRAY_SIZE(in));
> +               KUNIT_EXPECT_EQ(test, mock->msg.outsize, ARRAY_SIZE(out));
> +
> +               data = (u8 *)mock->i_data;
> +               KUNIT_EXPECT_EQ(test, data[0], 0xdd);
> +               KUNIT_EXPECT_EQ(test, data[1], 0xcc);
> +               KUNIT_EXPECT_EQ(test, data[2], 0xbb);
> +       }
> +}
> +
>  static void cros_ec_proto_test_release(struct device *dev)
>  {
>  }
> @@ -2690,6 +2737,7 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
>         KUNIT_CASE(cros_ec_proto_test_get_sensor_count_normal),
>         KUNIT_CASE(cros_ec_proto_test_get_sensor_count_xfer_error),
>         KUNIT_CASE(cros_ec_proto_test_get_sensor_count_legacy),
> +       KUNIT_CASE(cros_ec_proto_test_ec_cmd),
>         {}
>  };
>
> --
> 2.37.0.rc0.104.g0611611a94-goog
>