linux-kernel - Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for Rembrandt platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a210c39-2a04-2d39-9d5f-51b4e777b81d@infradead.org>
Date:   Fri, 24 Jun 2022 16:04:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     V sujith kumar Reddy <Vsujithkumar.Reddy@....com>,
        broonie@...nel.org, alsa-devel@...a-project.org
Cc:     Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, venkataprasad.potturu@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Arnd Bergmann <arnd@...db.de>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        Jia-Ju Bai <baijiaju1990@...il.com>,
        Syed Saba kareem <ssabakar@....com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Meng Tang <tangmeng@...ontech.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for
 Rembrandt platform

Hi--

On 6/24/22 12:48, V sujith kumar Reddy wrote:
> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
> index 7e56d2644105..abc089f38b6c 100644
> --- a/sound/soc/amd/acp/Kconfig
> +++ b/sound/soc/amd/acp/Kconfig
> @@ -40,6 +40,17 @@ config SND_AMD_ASOC_RENOIR
>  	help
>  	  This option enables Renoir I2S support on AMD platform.
>  
> +config SND_AMD_ASOC_REMBRANDT
> +        tristate "AMD ACP ASOC Rembrandt Support"
> +        select SND_SOC_AMD_ACP_PCM
> +        select SND_SOC_AMD_ACP_I2S
> +        select SND_SOC_AMD_ACP_PDM
> +        depends on X86 && PCI
> +        help
> +          This option enables Rembrandt I2S support on AMD platform.
> +	  Say Y if you want to enable AUDIO on Rembrandt
> +	  If unsure select "N".

Documentation/process/coding-style.rst says:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


so please indent as expected, and consistently.

-- 
~Randy