linux-kernel - Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for Rembrandt platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202206250650.DKkqPR4A-lkp@intel.com>
Date:   Sat, 25 Jun 2022 10:59:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     V sujith kumar Reddy <Vsujithkumar.Reddy@....com>,
        broonie@...nel.org, alsa-devel@...a-project.org
Cc:     kbuild-all@...ts.01.org, Sunil-kumar.Dommati@....com,
        open list <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        venkataprasad.potturu@....com, Meng Tang <tangmeng@...ontech.com>,
        Basavaraj.Hiregoudar@....com, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Jia-Ju Bai <baijiaju1990@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        Vijendar.Mukunda@....com,
        V sujith kumar Reddy <Vsujithkumar.Reddy@....com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Dan Carpenter <error27@...il.com>,
        Syed Saba kareem <ssabakar@....com>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for
 Rembrandt platform

Hi sujith,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on next-20220624]
[cannot apply to linus/master v5.19-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/V-sujith-kumar-Reddy/ADD-legacy-audio-driver-support-for-rembrandt/20220625-035009
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/32f53f63fb2ba0bbf7e8e145879a7340f28ebfbd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review V-sujith-kumar-Reddy/ADD-legacy-audio-driver-support-for-rembrandt/20220625-035009
        git checkout 32f53f63fb2ba0bbf7e8e145879a7340f28ebfbd
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/amd/acp/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> sound/soc/amd/acp/acp-rembrandt.c:264:5: warning: no previous prototype for 'rmb_acp_init' [-Wmissing-prototypes]
     264 | int rmb_acp_init(void __iomem *base)
         |     ^~~~~~~~~~~~
>> sound/soc/amd/acp/acp-rembrandt.c:286:5: warning: no previous prototype for 'rmb_acp_deinit' [-Wmissing-prototypes]
     286 | int rmb_acp_deinit(void __iomem *base)
         |     ^~~~~~~~~~~~~~


vim +/rmb_acp_init +264 sound/soc/amd/acp/acp-rembrandt.c

   263	
 > 264	int rmb_acp_init(void __iomem *base)
   265	{
   266		int ret;
   267	
   268		/* power on */
   269		ret = acp6x_power_on(base);
   270		if (ret) {
   271			pr_err("ACP power on failed\n");
   272			return ret;
   273		}
   274		writel(0x01, base + ACP_CONTROL);
   275	
   276		/* Reset */
   277		ret = acp6x_reset(base);
   278		if (ret) {
   279			pr_err("ACP reset failed\n");
   280			return ret;
   281		}
   282	
   283		return 0;
   284	}
   285	
 > 286	int rmb_acp_deinit(void __iomem *base)
   287	{
   288		int ret = 0;
   289	
   290		/* Reset */
   291		ret = acp6x_reset(base);
   292		if (ret) {
   293			pr_err("ACP reset failed\n");
   294			return ret;
   295		}
   296	
   297		writel(0x00, base + ACP_CONTROL);
   298	
   299		/* power off */
   300		ret = acp6x_power_off(base);
   301		if (ret) {
   302			pr_err("ACP power off failed\n");
   303			return ret;
   304		}
   305	
   306		return 0;
   307	}
   308	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (284242 bytes)