linux-kernel - Re: [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Jun 2022 08:10:38 -0700
From:   Yury Norov <yury.norov@...il.com>
To:     Qu Wenruo <wqu@...e.com>
Cc:     linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        linux@...musvillemoes.dk
Subject: Re: [PATCH] lib: bitmap: fix the duplicated comments on
 bitmap_to_arr64()

On Fri, Jun 24, 2022 at 05:31:47PM +0800, Qu Wenruo wrote:
> Thanks to the recent commit 0a97953fd221 ("lib: add
> bitmap_{from,to}_arr64") now we can directly convert a U64 value into a
> bitmap and vice verse.
> 
> However when checking the header there is duplicated helper for
> bitmap_to_arr64(), but no bitmap_from_arr64().
> 
> Just fix the copy-n-paste error.

I spotted it as well, but you're the first. :-) Thanks.
Applied in bitmap-for-next.

> Signed-off-by: Qu Wenruo <wqu@...e.com>
> ---
>  include/linux/bitmap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 2e6cd5681040..f091a1664bf1 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -71,9 +71,9 @@ struct device;
>   *  bitmap_release_region(bitmap, pos, order)   Free specified bit region
>   *  bitmap_allocate_region(bitmap, pos, order)  Allocate specified bit region
>   *  bitmap_from_arr32(dst, buf, nbits)          Copy nbits from u32[] buf to dst
> + *  bitmap_from_arr64(dst, buf, nbits)          Copy nbits from u64[] buf to dst
>   *  bitmap_to_arr32(buf, src, nbits)            Copy nbits from buf to u32[] dst
>   *  bitmap_to_arr64(buf, src, nbits)            Copy nbits from buf to u64[] dst
> - *  bitmap_to_arr64(buf, src, nbits)            Copy nbits from buf to u64[] dst
>   *  bitmap_get_value8(map, start)               Get 8bit value from map at start
>   *  bitmap_set_value8(map, value, start)        Set 8bit value to map at start
>   *
> -- 
> 2.36.1