linux-kernel - Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3dDJrPPM6gRc+s7OQStphWdvWRdcELtNBXSzvd+gxoLw@mail.gmail.com>
Date:   Fri, 24 Jun 2022 17:11:06 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Krzysztof Hałasa <khalasa@...p.pl>
Cc:     Miaoqian Lin <linmq006@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: cns3xxx: Fix refcount leak in cns3xxx_init

On Thu, Jun 23, 2022 at 10:36 AM Krzysztof Hałasa <khalasa@...p.pl> wrote:
>
> Miaoqian Lin <linmq006@...il.com> writes:
>
> > of_find_compatible_node() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when done.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 415f59142d9d ("ARM: cns3xxx: initial DT support")
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
>
> Acked-by: Krzysztof Halasa <khalasa@...p.pl>
>
> Arnd, I guess you are in the best position to pick this patch up?
> Thanks to both of you.

Done now, thanks!

        Arnd