[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220625082813.3b70727c@redslave.neermore.group>
Date: Sat, 25 Jun 2022 08:28:13 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Atish Patra <atishp@...shpatra.org>,
Anup Patel <anup@...infault.org>,
João Mário Domingos
<joao.mario@...nico.ulisboa.pt>, linux@...ro.com,
Nikita Shubin <n.shubin@...ro.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v4 2/5] perf tools riscv: Add support for get_cpuid_str
function
Hello Arnaldo!
On Fri, 24 Jun 2022 13:32:20 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > + if (mimpid)
> > + free(mimpid);
>
> just use:
>
>
> free(mvendorid);
> free(marchid);
> free(mimpid);
>
> fewer lines, free() accepts NULL.
>
> > +
> > + return cpuid;
> > +}
> > +
> > +int get_cpuid(char *buffer, size_t sz)
> > +{
> > + char *cpuid = _get_cpuid();
> > +
> > + if (sz < strlen(cpuid)) {
> > + free(cpuid);
> > + return -EINVAL;
> > + }
> > +
> > + scnprintf(buffer, sz, "%s", cpuid);
>
> You're leaking cpuid here.
Agree with both.
Thank you for pointing it out.
>
> > + return 0;
> > +}
> > +
> > +char *
> > +get_cpuid_str(struct perf_pmu *pmu __maybe_unused)
> > +{
> > + return _get_cpuid();
> > +}
> > --
> > 2.35.1
>
Powered by blists - more mailing lists