linux-kernel - Re: [PATCH v3 5/7] clk: mediatek: clk-apmixed: Remove unneeded _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Jun 2022 08:07:16 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <angelogioacchino.delregno@...labora.com>
CC:     <bgolaszewski@...libre.com>, <chun-jie.chen@...iatek.com>,
        <ck.hu@...iatek.com>, <devicetree@...r.kernel.org>,
        <fparent@...libre.com>, <ikjn@...omium.org>,
        <jason-jh.lin@...iatek.com>, <kernel@...labora.com>,
        <konrad.dybcio@...ainline.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <marijn.suijten@...ainline.org>, <martin.botka@...ainline.org>,
        <matthias.bgg@...il.com>, <miles.chen@...iatek.com>,
        <mturquette@...libre.com>, <p.zabel@...gutronix.de>,
        <paul.bouchara@...ainline.org>, <phone-devel@...r.kernel.org>,
        <rex-bc.chen@...iatek.com>, <robh+dt@...nel.org>,
        <sam.shih@...iatek.com>, <sboyd@...nel.org>,
        <tinghan.shen@...iatek.com>, <weiyi.lu@...iatek.com>,
        <wenst@...omium.org>, <y.oudjana@...tonmail.com>,
        <~postmarketos/upstreaming@...ts.sr.ht>
Subject: Re: [PATCH v3 5/7] clk: mediatek: clk-apmixed: Remove unneeded __init annotation

> Remove an unneeded __init annotation from the declaration of function
> mtk_clk_register_ref2usb_tx(): this avoids section mismatch warnings
> during modpost phase when called from functions that have no such
> annotation (useful when clocks are platform drivers).
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Miles Chen <miles.chen@...iatek.com> 

> ---
>  drivers/clk/mediatek/clk-apmixed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mediatek/clk-apmixed.c b/drivers/clk/mediatek/clk-apmixed.c
> index fc3d4146f482..6b0ab0a346e8 100644
> --- a/drivers/clk/mediatek/clk-apmixed.c
> +++ b/drivers/clk/mediatek/clk-apmixed.c
> @@ -70,7 +70,7 @@ static const struct clk_ops mtk_ref2usb_tx_ops = {
>  	.unprepare	= mtk_ref2usb_tx_unprepare,
>  };
>  
> -struct clk_hw * __init mtk_clk_register_ref2usb_tx(const char *name,
> +struct clk_hw *mtk_clk_register_ref2usb_tx(const char *name,
>  			const char *parent_name, void __iomem *reg)
>  {
>  	struct mtk_ref2usb_tx *tx;
> -- 
> 2.35.1