linux-kernel - Re: [RFC[ Alloc in vsprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220626200618.jhxu5lg4w7o2irhr@moria.home.lan>
Date:   Sun, 26 Jun 2022 16:06:18 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        David Laight <David.Laight@...LAB.COM>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Matthew Wilcox <willy@...radead.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>
Subject: Re: [RFC[ Alloc in vsprintf

On Sun, Jun 26, 2022 at 12:53:26PM -0700, Joe Perches wrote:
> In a reply to the printbufs thread, I wrote a proposal to use an
> alloc to reduce stack in vsprintf when CONFIG_KALLSYMS is enabled.
> 
> No one has replied to this but I think it's somewhat sensible.
> 
> Thoughts?

As functions get converted to printbufs the separate stack allocated buffers
become unnecessary, because printbufs have helpers that do bounds checking and
make outputting to the vsprintf buffer painless. So it's not necessary - I
haven't fully converted symbol_string() yet but I'll do so by the time I mail
out the next round of patches.