[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aafd58d6-8705-96ee-7813-9b3bae7bb3d1@linaro.org>
Date: Mon, 27 Jun 2022 11:35:15 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Quan Nguyen <quan@...amperecomputing.com>,
openbmc@...ts.ozlabs.org, Arnd Bergmann <arnd@...db.de>,
Olof Johansson <olof@...om.net>, soc@...nel.org,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
Open Source Submission <patches@...erecomputing.com>
Cc: Phong Vo <phong@...amperecomputing.com>,
"Thang Q . Nguyen" <thang@...amperecomputing.com>
Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt.
Mitchell BMC
On 27/06/2022 11:32, Quan Nguyen wrote:
>>> +
>>> + ltc2497_reg: ltc2497_regulator {
>>
>> No underscores in node name, no specific names (Devicetree spec requires
>> generic), so ltc2497 has to go. You could add some more specific
>> prefix/suffix to describe the function.
>>
> This is to monitor peripheral voltage so it would be updated to:
But it is a regulator, not a voltage monitor, so the node name could be:
regulator-0
regulator-voltage-mon
voltage-mon-regulator
>
> voltage_monitor: voltage-monitor {
>
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "ltc2497_reg";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> +
Best regards,
Krzysztof
Powered by blists - more mailing lists