linux-kernel - Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <624cd43b-af83-402d-86bb-68e7242da0f7@os.amperecomputing.com>
Date:   Mon, 27 Jun 2022 16:44:43 +0700
From:   Quan Nguyen <quan@...amperecomputing.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        openbmc@...ts.ozlabs.org, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, soc@...nel.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        Open Source Submission <patches@...erecomputing.com>
Cc:     Phong Vo <phong@...amperecomputing.com>,
        "Thang Q . Nguyen" <thang@...amperecomputing.com>
Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt.
 Mitchell BMC

On 27/06/2022 16:35, Krzysztof Kozlowski wrote:
> On 27/06/2022 11:32, Quan Nguyen wrote:
>>>> +
>>>> +	ltc2497_reg: ltc2497_regulator {
>>>
>>> No underscores in node name, no specific names (Devicetree spec requires
>>> generic), so ltc2497 has to go. You could add some more specific
>>> prefix/suffix to describe the function.
>>>
>> This is to monitor peripheral voltage so it would be updated to:
> 
> But it is a regulator, not a voltage monitor, so the node name could be:
> regulator-0
> regulator-voltage-mon
> voltage-mon-regulator
> 
Yes, I think I would pick the voltage-mon-regulator:

            voltage_mon_reg: voltage-mon-monitor {

>>
>>            voltage_monitor: voltage-monitor {
>>
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "ltc2497_reg";
>>>> +		regulator-min-microvolt = <3300000>;
>>>> +		regulator-max-microvolt = <3300000>;
>>>> +		regulator-always-on;
>>>> +	};
>>>> +
> 
> 
Thanks a lot for the quick suggestion.
- Quan