linux-kernel - [PATCH v2 -next] vdpa/mlx5: Use eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220628123457.90884-1-xuqiang36@huawei.com>
Date:   Tue, 28 Jun 2022 12:34:57 +0000
From:   Xu Qiang <xuqiang36@...wei.com>
To:     <mst@...hat.com>, <jasowang@...hat.com>, <elic@...dia.com>,
        <si-wei.liu@...cle.com>, <parav@...dia.com>
CC:     <virtualization@...ts.linux-foundation.org>,
        <linux-kernel@...r.kernel.org>, <xuqiang36@...wei.com>,
        <rui.xiang@...wei.com>
Subject: [PATCH v2 -next] vdpa/mlx5: Use eth_zero_addr() to assign zero address

Using eth_zero_addr() to assign zero address instead of memset().

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Xu Qiang <xuqiang36@...wei.com>
---
v2:
- fix typo in commit log
 drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index e85c1d71f4ed..f738c78ef446 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1457,8 +1457,8 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
 
 	*ucast = rule;
 
-	memset(dmac_c, 0, ETH_ALEN);
-	memset(dmac_v, 0, ETH_ALEN);
+	eth_zero_addr(dmac_c);
+	eth_zero_addr(dmac_v);
 	dmac_c[0] = 1;
 	dmac_v[0] = 1;
 	rule = mlx5_add_flow_rules(ndev->rxft, spec, &flow_act, &dest, 1);
-- 
2.17.1