linux-kernel - Re: [PATCH net-next v9 05/16] net: pcs: add Renesas MII converter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220628184954.6757ffe4@fixe.home>
Date:   Tue, 28 Jun 2022 18:49:54 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Herve Codina <herve.codina@...tlin.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        Milan Stevanovic <milan.stevanovic@...com>,
        Jimmy Lalande <jimmy.lalande@...com>,
        Pascal Eberhard <pascal.eberhard@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v9 05/16] net: pcs: add Renesas MII converter
 driver

Le Tue, 28 Jun 2022 17:42:58 +0100,
"Russell King (Oracle)" <linux@...linux.org.uk> a écrit :

> > +		break;
> > +	default:
> > +		return -EOPNOTSUPP;
> > +	}
> > +
> > +	val = FIELD_PREP(MIIC_CONVCTRL_CONV_MODE, conv_mode) |
> > +	      FIELD_PREP(MIIC_CONVCTRL_CONV_SPEED, speed);
> > +
> > +	miic_reg_rmw(miic, MIIC_CONVCTRL(port),
> > +		     MIIC_CONVCTRL_CONV_MODE | MIIC_CONVCTRL_CONV_SPEED, val);
> > +	miic_converter_enable(miic_port->miic, miic_port->port, 1);
> > +
> > +	return 0;
> > +}  
> 
> the stting of the speed here. As this function can be called as a result
> of ethtool setting the configuration while the link is up, this could
> have disasterous effects on the link. This will only happen if there is
> no PHY present and we aren't using fixed-link mode.
> 
> Therefore, I'm willing to get this pass, but I think it would be better
> if the speed was only updated if the interface setting is actually
> being changed. So:

Hi Russell,

Ok, I'll make a follow-up patch to handle that properly.

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com