linux-kernel - Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d26b8345-02e9-e461-c506-b429c44f74df@omp.ru>
Date:   Tue, 28 Jun 2022 21:39:04 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        John Garry <john.garry@...wei.com>
CC:     <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

On 6/28/22 1:05 PM, Sergey Shtylyov wrote:
[...]
>>> x86_64 allmodconfig build with W=1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .

   Wait, what do you mean by "stubbed", the version in <asm/paravirt.h>?

>>>
>>> Signed-off-by: John Garry <john.garry@...wei.com>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey