linux-kernel - Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fd807fd-f019-4ad2-7f4f-6746e05098bf@opensource.wdc.com>
Date:   Wed, 29 Jun 2022 10:14:52 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        John Garry <john.garry@...wei.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

On 6/28/22 19:05, Sergey Shtylyov wrote:
> Hello!
> 
> On 6/28/22 11:59 AM, Damien Le Moal wrote:
> [...]
>>> x86_64 allmodconfig build with W=1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>>
>>> Signed-off-by: John Garry <john.garry@...wei.com>
> 
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
>> Looks good, but I wonder why I am not getting this warning. I always do
>> W=1 and C=1 builds. I tried allmodconfig now and I am not getting the
>> warning...
> 
>    I can confirm the (fatal) warnings with RedHat gcc 10.3.1... but somehow they only
> occur on x86_64 with allmodconfig indeed (which is strange)...

Compiling on x86_64 with allmodconfig with gcc 12 and sparse-0.6.4-2
(Fedora 36) does not give the warning... Weird.

> 
> [...]
> 
> MBR, Sergey
> 


-- 
Damien Le Moal
Western Digital Research