linux-kernel - Re:Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39ad3f64.3de2.181a8dea7a0.Coremail.windhl@126.com>
Date:   Tue, 28 Jun 2022 13:52:53 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Tony Lindgren" <tony@...mide.com>
Cc:     linux@...linux.org.uk, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug




At 2022-06-28 12:38:49, "Tony Lindgren" <tony@...mide.com> wrote:
>* Liang He <windhl@....com> [220617 06:51]:
>> In omap4_sram_init(), of_find_compatible_node() will return a node
>> pointer with refcount incremented. We should use of_node_put() when
>> it is not used anymore.
>> 
>> Signed-off-by: Liang He <windhl@....com>
>> ---
>>  arch/arm/mach-omap2/omap4-common.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
>> index 6d1eb4eefefe..e981bf57e64f 100644
>> --- a/arch/arm/mach-omap2/omap4-common.c
>> +++ b/arch/arm/mach-omap2/omap4-common.c
>> @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void)
>>  		pr_warn("%s:Unable to allocate sram needed to handle errata I688\n",
>>  			__func__);
>>  	sram_pool = of_gen_pool_get(np, "sram", 0);
>> +	of_node_put(np);
>>  	if (!sram_pool)
>>  		pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
>>  			__func__);
>
>Here too sram_pool is used aftger of_node_put().
>
>Regards,
>
>Tony

Thanks, Tony.

I will send a new patch to fix the order problem.

Liang