linux-kernel - Re:Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b994fd6.3db9.181a8ddb1e9.Coremail.windhl@126.com>
Date:   Tue, 28 Jun 2022 13:51:50 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Tony Lindgren" <tony@...mide.com>
Cc:     linux@...linux.org.uk, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in
 omap_hwmod.c



At 2022-06-28 12:57:12, "Tony Lindgren" <tony@...mide.com> wrote:
>Hi,
>
>* Liang He <windhl@....com> [220618 04:43]:
>> In _init(), of_find_node_by_name() will return a node pointer with
>> refcount incremented. We should use of_node_put() in fail path or
>> when it is not used anymore.
>> 
>> NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(),
>> in normal exit path, we should call of_node_put() at the end use of 'np',
>> not the end use of 'bus'.
>
>Looks correct to me. What about missing of_node_put() for
>of_get_next_child() also in the _init() function?
>
>Regards,
>
>Tony

Thanks, Tony.

I have found this bug but not send the patch for of_get_next_child()
as I am collecting other OF function related bugs and I have been told that it is better 
to collect all similar bugs in same directory, then finally report them.

So I will send a new patch for both of the two missing 'put' bugs caused by
of_find_xxx() and of_get_xxx() in omap_hwmod.c

Thanks gain.

Liang