linux-kernel - Re: [PATCH] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17cba42b-0345-fdb2-69e3-cfc3f310c2f1@microchip.com>
Date:   Tue, 28 Jun 2022 07:12:53 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <trix@...hat.com>, <Lewis.Hanly@...rochip.com>,
        <a.zummo@...ertech.it>, <alexandre.belloni@...tlin.com>,
        <Daire.McNamara@...rochip.com>
CC:     <linux-riscv@...ts.infradead.org>, <linux-rtc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: remove 'pending' variable from
 mpfs_rtc_wakeup_irq_handler()

On 27/06/2022 21:59, Tom Rix wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> cppcheck reports
> [drivers/rtc/rtc-mpfs.c:219]: (style) Variable 'pending' is assigned a value that is never used.
> 
> The fetched CONTROL_REG stored in pending is unused and partially
> duplicates the functionality of the later call to mpfs_rtc_clear().  This looks
> like leftover development code, so remove pending.

It predates my involvement with the driver so I am not sure why
exactly it was introduced, but it looks to me to be surplus to
requirements.

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> 
> Fixes: 0b31d703598d ("rtc: Add driver for Microchip PolarFire SoC")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/rtc/rtc-mpfs.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c
> index db9c638e50f7..f14d1925e0c9 100644
> --- a/drivers/rtc/rtc-mpfs.c
> +++ b/drivers/rtc/rtc-mpfs.c
> @@ -213,10 +213,7 @@ static inline struct clk *mpfs_rtc_init_clk(struct device *dev)
>   static irqreturn_t mpfs_rtc_wakeup_irq_handler(int irq, void *dev)
>   {
>          struct mpfs_rtc_dev *rtcdev = dev;
> -       unsigned long pending;
> 
> -       pending = readl(rtcdev->base + CONTROL_REG);
> -       pending &= CONTROL_ALARM_ON_BIT;
>          mpfs_rtc_clear_irq(rtcdev);
> 
>          rtc_update_irq(rtcdev->rtc, 1, RTC_IRQF | RTC_AF);
> --
> 2.27.0
>