linux-kernel - Re: [PATCH] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165884535076.3156642.16325816554140473959.b4-ty@bootlin.com>
Date:   Tue, 26 Jul 2022 16:22:50 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     lewis.hanly@...rochip.com, conor.dooley@...rochip.com,
        trix@...hat.com, daire.mcnamara@...rochip.com, a.zummo@...ertech.it
Cc:     linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: remove 'pending' variable from
 mpfs_rtc_wakeup_irq_handler()

On Mon, 27 Jun 2022 16:59:43 -0400, Tom Rix wrote:
> cppcheck reports
> [drivers/rtc/rtc-mpfs.c:219]: (style) Variable 'pending' is assigned a value that is never used.
> 
> The fetched CONTROL_REG stored in pending is unused and partially
> duplicates the functionality of the later call to mpfs_rtc_clear().  This looks
> like leftover development code, so remove pending.
> 
> [...]

Applied, thanks!

[1/1] rtc: remove 'pending' variable from mpfs_rtc_wakeup_irq_handler()
      commit: 3fa0cb37bda9d45d3c6f07e67051e7118d3ffe63

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com