linux-kernel - Re: [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive register fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Jun 2022 06:33:04 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Christian Marangi <ansuelsmth@...il.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Sibi Sankar <sibis@...eaurora.org>,
        Saravana Kannan <skannan@...eaurora.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: Fix kernel warning with cpufreq passive
 register fail

On 22. 6. 20. 07:29, Christian Marangi wrote:
> Remove cpufreq_passive_unregister_notifier from
> cpufreq_passive_register_notifier in case of error as devfreq core
> already call unregister on GOV_START fail.
> 
> This fix the kernel always printing a WARN on governor PROBE_DEFER as
> cpufreq_passive_unregister_notifier is called two times and return
> error on the second call as the cpufreq is already unregistered.
> 
> Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  drivers/devfreq/governor_passive.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> index 72c67979ebe1..8055801cf182 100644
> --- a/drivers/devfreq/governor_passive.c
> +++ b/drivers/devfreq/governor_passive.c
> @@ -336,7 +336,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
>  err_put_policy:
>  	cpufreq_cpu_put(policy);
>  err:
> -	WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
>  
>  	return ret;
>  }

Applied. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi